Cleaned up and added some new information#71
Conversation
|
The fail is due to flake8. It gives the F405 error for all the |
| F_xt.jp(shift_y.v(buf=1)[index], buf=1)[index])) | ||
|
|
||
| return F_x, F_y | ||
| return F_x, F_y No newline at end of file |
There was a problem hiding this comment.
This deletion of the new line is causing flake8 to complain
|
This looks like it's because I also see the error
|
|
Ok, I've fixed all the flake8 F405 complaints now. If you could just fix that other tiny flake8 issue then this should be good to merge |
|
@harpolea I fixed the newline problem as well as |
|
Hmm ok, I think this annoyingly may be something to do with the text editor you're using - sometimes editors add extra newline characters at the ends of files without you noticing. If I view the file on github, there's no extra line, but if I open the raw file in my text editor then there's an extra blank line there. Everything else looks good though so I'll merge then fix that file so flake8 is happy. Thanks for your quick changes! |
|
@harpolea Great! I use vim for editing the files. Thank you. |
2 participants
I cleaned up the advection non-uniform solver and removed the redundant test problems, keeping only the slotted problem. Also added the required solver's parameters the solver's inc file. I added my information to the paper as well.